This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Better logging when mining own transactions. #9363
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we log
Transaction is mined
for every local (own) transaction that is dropped from the queue.In fact it's not always true, if the same key is used on some other nodes or if we send multiple replacement transactions (bumping gas price, but using the same nonce) - the transaction might be removed, but some other transaction with the same (sender, nonce) was actually included in the blockchain.
This PR attempts to fix the logging for local transactions by checking if the transaction is in chain before printing the log line.
Since we don't have a
client
instance in the miner, we do that by using aWeak
reference (to prevent cyclic references).